v2.7.0 - Merge duration fix and protocol v5 #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the logic for encoding query and execute requests is the same. This unifies most of that logic into the Statement class.
* Force 3.10 and later C* versions to be tested with v5.
added 3 commits
April 28, 2017 08:37
* Fix unit tests
* Removed trailing comma from protocol enumeration
mikefero
suggested changes
May 8, 2017
Contributor
mikefero
left a comment
mikefero
left a comment
There was a problem hiding this comment.
Merge looks good; only saw two things that may not be a fit for the core (and they are the same thing)
src/constants.hpp
Outdated
| #define CASS_QUERY_FLAG_DEFAULT_TIMESTAMP 0x00000020 | ||
| #define CASS_QUERY_FLAG_NAMES_FOR_VALUES 0x00000040 | ||
| #define CASS_QUERY_FLAG_PAGE_SIZE_BYTES 0x40000000 | ||
| #define CASS_QUERY_FLAG_CONTINUOUS_PAGING 0x80000000 |
Contributor
There was a problem hiding this comment.
Are these last two applicable to core?
src/constants.hpp
Outdated
| #define CASS_RESULT_FLAG_HAS_MORE_PAGES 0x00000002 | ||
| #define CASS_RESULT_FLAG_NO_METADATA 0x00000004 | ||
| #define CASS_RESULT_FLAG_CONTINUOUS_PAGING 0x40000000 | ||
| #define CASS_RESULT_FLAG_LAST_CONTINUOUS_PAGE 0x80000000 |
added 2 commits
May 8, 2017 15:08
* Removed unused paging constants
mikefero
approved these changes
May 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.